Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samarium: migrate to Conan v2, drop old version #25396

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

samarium: migrate to Conan v2, drop old version #25396

wants to merge 8 commits into from
+88 −184

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 24, 2024 •
edited
Loading

Summary

Changes to recipe: lib/[version]

Motivation

Details

The author appears to have changed their username. The source archive hash has not changed, though.

@valgur valgur mentioned this pull request Sep 24, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbrilRBS AbrilRBS self-assigned this Sep 25, 2024
@AbrilRBS
Copy link
Member

Seems like there are still some missing libraries there! Ping me once this gets fixed :)

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit e9c6905
samarium/1.0.1@#5e9b4b2dec4d2723f3006978593ebf00 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsamarium.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsamarium.1.0.1.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsamarium.1.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 431269b
samarium/1.0.1@#1d64693a4a900f3082e2137ec4e03efc 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsamarium.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsamarium.1.0.1.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsamarium.1.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.

@valgur
Copy link
Contributor Author

valgur commented Sep 26, 2024

The CoreGraphics warnings are a false-positive from SFML, where CoreGraphics is a transitive dependency of another macOS framework.

AbrilRBS
AbrilRBS previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

recipes/samarium/all/conanfile.py Show resolved Hide resolved
recipes/samarium/all/conanfile.py
"Unknown compiler, assuming it supports at least C++20")
return
def requirements(self):
# Undefined symbols for architecture arm64: "void fmt::v10::detail::vformat_to..." when using sm::print
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these comments for future traceability

@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS previously approved these changes Sep 27, 2024
View reviewed changes
@conan-center-bot

This comment was marked as outdated.

Sign in to view
@AbrilRBS AbrilRBS assigned perseoGI and unassigned AbrilRBS Dec 3, 2024
@perseoGI perseoGI removed their assignment Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@AbrilRBS AbrilRBS AbrilRBS left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @AbrilRBS @perseoGI